reenable basic sample tests, serially after frontend integ tests(triggering 5 times, successful always) #298
Conversation
|
/test presubmit-e2e-test |
gaoning777
changed the title
|
/test presubmit-e2e-test |
1 similar comment
|
/test presubmit-e2e-test |
|
It works continuously when I manually triggered it at least four times. |
|
/test presubmit-e2e-test |
gaoning777
changed the title
|
fix #272 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Did something change between this and the original code before revert? Why is this not flaky? |
|
I've commented in #272 that the reasons for the flakiness comes from the cluster creation quota and accidentally being shutdown manually. |
|
I see. Interesting coincidence with how tests got flaky only when this change was checked in, but if you've tested it a few times here then I'm fine with trying it out again. |
|
The one failed in the 8-runs is that one of the commit force push one commit that overrides the previous one. And, the tests failed when git checkout. |
|
And, BTW, in this PR, I run the tests concurrently with the frontend integration tests. |
|
Yes I noticed. Fingers crossed! 🤞 |
* Add checkout-snapshot.sh * finish script * add repo-clone-snapshot to init.sh * add some args
…ubeflow#299) * New server API: read run log - The new server API endpoint (/apis/v1beta1/runs/{run_id}/nodes/{node_id}/log) to fetch run log - UI (RunDetails) changes to fetch log from server API instead of direct access to cluster and ObjectStore * Redundant comment * New server API: read run log - ml-pipeline rbac update: allow for access to log * Read run log: enhanced error handling - log message on Pod access errors * Merged changes from upstream: kubeflow@6135ca5 - `ARCHIVE_LOG_FILE_NAME` and `ARCHIVE_LOG_PATH_PREFIX` options allows to control archive log path - UI Server fetches logs from server API or directly from k8s depending on `STREAM_LOGS_FROM_SERVER_API` option * Cherry-pick 76ba10b from rafalbigaj:master * Log archive - tekton adaptations * Archival default log file name: step-main.tgz
will trigger multiple rerun and make sure there is no issue with frontend integ tests.
This change is