Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Adding Troubleshooting guide link to Error / Warning Banner #2930

Merged
merged 6 commits into from
Jan 31, 2020
Merged

[UI] Adding Troubleshooting guide link to Error / Warning Banner #2930

merged 6 commits into from
Jan 31, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Jan 29, 2020 •
edited by jlewi
Loading

Adding a UI link to FAQ / Trouble shooting guide when pipelines fail. This is WIP posting for early feedback.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from Bobgy and IronPan January 29, 2020 21:06
@SinaChavoshi SinaChavoshi changed the title [WIP] UI updated for daignose_me and FAQ Page Updating Error / Warning Banner with link to Troubleshooting guide Jan 30, 2020
@SinaChavoshi SinaChavoshi changed the title Updating Error / Warning Banner with link to Troubleshooting guide [UI] Updating Error / Warning Banner with link to Troubleshooting guide Jan 30, 2020
@SinaChavoshi SinaChavoshi changed the title [UI] Updating Error / Warning Banner with link to Troubleshooting guide [UI] Adding Troubleshooting guide link to Error / Warning Banner Jan 30, 2020
@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-frontend-test

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-frontend-test

@SinaChavoshi
Copy link
Contributor Author

/retest

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test
/test kubeflow-pipeline-e2e-test

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@SinaChavoshi
Copy link
Contributor Author

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Jan 31, 2020

This is a good idea!
Can you post a screenshot here so it's easier to review?

@SinaChavoshi
Copy link
Contributor Author

/retest

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

1 similar comment
@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member

IronPan commented Jan 31, 2020

/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 31, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8b6bf7e into kubeflow:master Jan 31, 2020
@SinaChavoshi SinaChavoshi deleted the pipeline_error_ui branch February 7, 2020 15:54
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@SinaChavoshi @Jeffwan
[UI] Adding Troubleshooting guide link to Error / Warning Banner (kub…
e437d89 
…eflow#2930)

* [WIP] UI updated for daignose_me and FAQ Page

* Added message to banner directly and update test

* mintor changes to remove extra space

* changed Details button to match refresh

* Fixing formatting error

* Removing redundant CSS for troubleshooting link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy left review comments

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@Ark-kun Ark-kun

@IronPan IronPan

Labels
approved area/frontend lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SinaChavoshi @Bobgy @IronPan @k8s-ci-robot @Ark-kun