Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLMD][Lineage] Integrate Lineage View into KFP #2918

Merged
merged 31 commits into from
Jan 31, 2020
Merged

[MLMD][Lineage] Integrate Lineage View into KFP #2918

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
afadec7
Minimal change to verify that the new image will work on Marketplace
kwasi Jan 8, 2020
84b26ec
Very rough working copy of LineageView in KFP
kwasi Jan 10, 2020
439fb71
Update kubeflow-frontend dependency
kwasi Jan 10, 2020
0a1b712
Fix lint errors
kwasi Jan 10, 2020
8380bd6
Update to latest version of kubeflow-frontend
kwasi Jan 13, 2020
11b98df
Bump kubeflow/frontend hash to latest version with pre-built library
kwasi Jan 14, 2020
040d231
Remove debug string
kwasi Jan 14, 2020
ab09edd
Merge branch 'master' of https://github.com/kwasi/pipelines into line…
kwasi Jan 27, 2020
fb9a42f
Replace metadata APIs with versions from kubeflow/frontend
kwasi Jan 27, 2020
64c5f5d
Use latest dev version of kubeflow/frontend package
kwasi Jan 27, 2020
dc57612
Pass route builder to ArtifactDetails for building details pages routes
kwasi Jan 27, 2020
05ffa28
Review ResourcesInfo.tsx
kwasi Jan 28, 2020
9fbafb3
Review changes part 2
kwasi Jan 28, 2020
db31466
Revert change to Status snapshot
kwasi Jan 28, 2020
8834e28
Revert Status snapshot to master
kwasi Jan 28, 2020
77d685f
Remove unneeded @ts-ignore
kwasi Jan 28, 2020
bae4b24
Bump to latest mainline kubeflow/frontend hash
kwasi Jan 28, 2020
6b07996
Merge branch 'master' of https://github.com/kwasi/pipelines into line…
kwasi Jan 29, 2020
c3c2c1c
Respond to comments PR comments
kwasi Jan 29, 2020
6d254db
Add missing await when loading ArtifactList
kwasi Jan 29, 2020
817735c
Fix casing on global constants in ArtifactDetails
kwasi Jan 29, 2020
a9d7ae0
Improve readability on ExecutionList.tsx
kwasi Jan 29, 2020
35476ee
Remove `()!` pattern caused by not having @types/google-protobuf
kwasi Jan 29, 2020
d828e88
Remove a stray @ts-ignore
kwasi Jan 29, 2020
fdda54c
Remove side effects from getRowsFrom{Artifacts,Executions}
kwasi Jan 29, 2020
a326d93
Add error handling back to Artifact and Execution pages
kwasi Jan 30, 2020
d7c1ffd
Fix error message handling on getArtifacts()
kwasi Jan 30, 2020
82ccb80
Fix ArtifactList response
kwasi Jan 30, 2020
a2a4d6b
Check for potentially undefined `code` in serviceErrorToString
kwasi Jan 30, 2020
a2f4476
Restore missing error handlers
kwasi Jan 30, 2020
073460f
Merge branch 'master' of https://github.com/kubeflow/pipelines into l…
kwasi Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/gen_licenses.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ const path = require('path');
const start = path.resolve(process.cwd(), process.argv[2]);
let licenseMissing = 0;
const whitelist = new Map([
['@jest/environment', 'third_party/jest/LICENSE'],
['@jest/reporters', 'third_party/jest/LICENSE'],
['@jest/test-sequencer', 'third_party/jest/LICENSE'],
['@jest/transform', 'third_party/jest/LICENSE'],
['eslint-module-utils', 'third_party/eslint/LICENSE'],
['@kubernetes/client-node', 'third_party/@kubernetes/client-node/LICENSE'],
['expect', 'third_party/jest/LICENSE'],
['jest-config', 'third_party/jest/LICENSE'],
Expand All @@ -47,6 +52,7 @@ const whitelist = new Map([
['jest-runtime', 'third_party/jest/LICENSE'],
['jest-snapshot', 'third_party/jest/LICENSE'],
['jest-util', 'third_party/jest/LICENSE'],
['mamacro', 'third_party/mamacro/LICENSE'],
]);

licenseChecker.init({
Expand Down
36,005 changes: 25,418 additions & 10,587 deletions frontend/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 3 additions & 5 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@grpc/proto-loader": "^0.3.0",
"@kubeflow/frontend": "kubeflow/frontend#756476a",
"@material-ui/core": "3.7.1",
"@material-ui/icons": "^3.0.1",
"@types/js-yaml": "^3.11.2",
Expand All @@ -12,8 +12,6 @@
"d3-dsv": "^1.0.10",
"dagre": "^0.8.2",
"google-protobuf": "^3.6.1",
"grpc": "^1.15.0",
"grpc-web": "^1.0.0",
"http-proxy-middleware": "^0.19.0",
"immer": "^1.7.4",
"js-yaml": "^3.13.1",
Expand All @@ -29,7 +27,6 @@
"react-scripts-ts": "2.17.0",
"react-virtualized": "^9.20.1",
"react-vis": "^1.11.2",
"ts-protoc-gen": "^0.10.0",
"typestyle": "^2.0.1"
},
"scripts": {
Expand All @@ -50,7 +47,7 @@
"lint": "tslint -c ./tslint.prod.json -p .",
"mock:api": "ts-node-dev -O '{\"module\": \"commonjs\"}' mock-backend/mock-api-server.ts 3001",
"mock:server": "node server/dist/server.js build",
"postinstall": "cd ./server && npm i && cd ../mock-backend && npm i && cd ../src/generated/src/apis/metadata && npm i",
"postinstall": "cd ./server && npm i && cd ../mock-backend && npm i",
"start:proxy-standalone": "./start-proxy-standalone.sh",
"start:proxy-standalone-and-server": "./start-proxy-standalone-and-server.sh",
"start": "react-scripts-ts start",
Expand All @@ -70,6 +67,7 @@
"@types/enzyme": "^3.10.3",
"@types/enzyme-adapter-react-16": "^1.0.5",
"@types/express": "^4.16.0",
"@types/google-protobuf": "^3.7.2",
"@types/http-proxy-middleware": "^0.17.5",
"@types/jest": "^23.3.2",
"@types/js-yaml": "^3.11.2",
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/components/ResourceInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Artifact, Execution, getMetadataValue } from '@kubeflow/frontend';
import * as React from 'react';
import { stylesheet } from 'typestyle';
import { color, commonCss } from '../Css';
import { getMetadataValue } from '../lib/Utils';
import { Artifact, Execution } from '../generated/src/apis/metadata/metadata_store_pb';
import { ArtifactLink } from './ArtifactLink';

export const css = stylesheet({
Expand Down
Loading