Kfp diagnose_me pipeline #2843
Merged
Kfp diagnose_me pipeline #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
good catch :) Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
/assign @numerology |
numerology
reviewed
Jan 15, 2020
|
Please see the comments via ReviewNB. Its visualization compatibility with Github is not great. |
numerology
reviewed
Jan 21, 2020
|
LGTM modulo one nit issue :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Making json output format easier to read * Update sdk/python/kfp/cli/diagnose_me_cli.py good catch :) Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com> * update based on feedback * Sample env validation pipeline with diagnose_me * removing files that I accidentally added * update based on review feedback * diagnose_me based validation pipeline * updating sample based on review feedback * updating project_id comment * removed sequential execution * changing comment on base image Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a pipeline based on diagnose_me code to that helps verify credentials, enabled APIs, and cloud scope.
The pipeline runs diangose_me as a first step to make it easy for users to capture their environment configuration and share the results with support teams.
This change is