Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] PowerShell script added to start proxies for front-end UI #2835

Merged
merged 3 commits into from
Jan 23, 2020

Conversation

avdaredevil
Copy link
Contributor

@avdaredevil avdaredevil commented Jan 13, 2020

About

This PR adds a cross-platform PowerShell script that can deploy proxies for Mac / Linux / Windows environments.

Image
image

Note: I don't have a properly deployed cluster currently, but it's identical to the Linux counterpart found here

Meta

/area pipelines
/area front-end
/priority p1
/assign @avdaredevil
/cc @kwasi @Bobgy


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Jan 14, 2020

Hi @avdaredevil, I later realized the script could be vastly simplified by port-forwarding services directly: #2836.

Can you adjust your script too?

@Bobgy
Copy link
Contributor

Bobgy commented Jan 14, 2020

Some discussion:
Is powershell in linux well supported? https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-core-on-linux?view=powershell-7
Can we take other approaches like writing node scripts for this?
In windows, can we use mingw to run these?

@avdaredevil
Copy link
Contributor Author

Hi @Bobgy, thanks for the insights:

  • Is powershell in linux well supported? https://docs...
    • Not all parts of powershell, as in the .NET Core which is not used in this script (since .NET core is a really fundamental part of windows. However this should change with PwShell v7 coming out this year). But for this PR, this is a non-issue
  • Can we take other approaches like writing node scripts for this?
    • Definitely, and in fact this would be the preferred way! (this in conjuction with using cross-env in package.json)
  • In windows, can we use mingw to run these?
    • Yes, but this is not a good solution, as it requires non-standard installations of Linux build tools to run really trivial scripts. (which do not auto-update, or get patches)

@Bobgy
Copy link
Contributor

Bobgy commented Jan 23, 2020

sounds like node scripts will be the best option going forward. I will try writing more of it.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 23, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Jan 23, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 719f407 into kubeflow:master Jan 23, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…ubeflow#2835)

* Powershell script added to start proxies for front-end UI

* Commented code

* Simplified based on edits from kubeflow#2836
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Upgrade HPA reconciler to use autoscaling/v2 API version

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix qpext e2e test

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Upgrade k8s version to 1.26 for tests

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Upgrade tests to autoscaling v2

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Upgrade knative and istio for tests

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix pod communication failure

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Downgrade minikube to 1.28

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Patch knative external domain

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants