Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the namespace for Delete/Terminate/Retry run APIs #2765

Merged
merged 4 commits into from
Jan 2, 2020
Merged

Adjust the namespace for Delete/Terminate/Retry run APIs #2765

merged 4 commits into from
Jan 2, 2020

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Dec 20, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Dec 21, 2019

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 2, 2020
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

IronPan
IronPan reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@IronPan IronPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 6c34ea3 into kubeflow:master Jan 2, 2020
@gaoning777 gaoning777 deleted the fix-bug-for-run-apis branch January 2, 2020 19:58
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@gaoning777 @Jeffwan
Adjust the namespace for Delete/Terminate/Retry run APIs (kubeflow#2765)
6d8e02f 
* delete/terminate run in the corresponding namespace

* retry run in the corresponding namespace; wrap pod client with kubernetes core client

* fix duplicate build rules
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@andyi2it
Fix running out of disk space in e2e (kubeflow#2765)
e3a1081 
Torchvision has a new release 0.15.1 and the image size has increased by almost 1 Gb. Hence the build failures.
Pinning torchvision to 0.14.1.
Upgrade to newer version of torchvision will be done in near future.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan left review comments

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

Assignees

@IronPan IronPan

@Bobgy Bobgy

@jingzhang36 jingzhang36

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaoning777 @Bobgy @k8s-ci-robot @IronPan @jingzhang36