SDK/DSL: Fix PipelineVolume name length #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
reviewed
Dec 16, 2019
Volume name must be no more than 63 characters Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
elikatsis
force-pushed
the
fix-pvolume-name-length
branch
from
d62659b to
f3f1c8f
Compare
|
The errors seem unrelated to the change. I rebased on top of |
elikatsis
force-pushed
the
fix-pvolume-name-length
branch
3 times, most recently
from
2ec5305 to
f9bf52a
Compare
Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
elikatsis
force-pushed
the
fix-pvolume-name-length
branch
from
f9bf52a to
fd34e47
Compare
Ark-kun
reviewed
Dec 17, 2019
| sort_keys=True), | ||
| "utf-8")).hexdigest() | ||
| name = "pvolume-{}".format(hash_value) | ||
| self.name = name[0:63] if len(name) > 63 else name |
There was a problem hiding this comment.
JFYI: name[0:63] works fine even when length is less than 63 characters.
There was a problem hiding this comment.
Oh, didn't know, thanks! Should I change and push it?
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* SDK/DSL: Fix PipelineVolume name length Volume name must be no more than 63 characters Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com> * Change which part of the hash value we make use of Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Rachit Chauhan <rachitchauhan43@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volume name must be no more than 63 characters
Signed-off-by: Ilias Katsakioris elikatsis@arrikto.com
Example of faulty behavior mentioned in kubeflow-kale/kale#30:
This change is