Metadata: Adding metadata-grpc config map #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @neuromage @rmgogogo |
neuromage
reviewed
Dec 12, 2019
| @@ -58,17 +58,17 @@ spec: | |||
| - name: MYSQL_DATABASE | |||
| valueFrom: | |||
| configMapKeyRef: | |||
| name: metadata-configmap | |||
| name: metadata-mysql-configmap | |||
There was a problem hiding this comment.
Let's keep this around and add a new config map to maintain backward compatibility.
dushyanthsc
force-pushed
the
dushyanthsc/tfx-metadata-grpc
branch
from
69eb6cf
to
a2e4246
Compare
neuromage
reviewed
Dec 12, 2019
| labels: | ||
| component: metadata-server | ||
| data: | ||
| mysql_database: "metadb" |
There was a problem hiding this comment.
As discussed let's maybe make the keys upper case to be consistent
This change adds the necessary config-map related to gRPC MLMD server. To make the names more clear, this change also modifies the existing 'metadata-configmap' which provides mysql configurations to 'metadata-mysql-configmap'
dushyanthsc
force-pushed
the
dushyanthsc/tfx-metadata-grpc
branch
from
a2e4246
to
7bf6c2e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the necessary config-map related to gRPC MLMD server.
To make the names more clear, this change also modifies the existing 'metadata-configmap' which provides mysql configurations to 'metadata-mysql-configmap'
This change is