Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kfam service host env variable #2715

Merged
merged 1 commit into from
Dec 11, 2019
Merged

update kfam service host env variable #2715

merged 1 commit into from
Dec 11, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Dec 11, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Dec 11, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member

IronPan commented Dec 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0548e63 into kubeflow:master Dec 11, 2019
@gaoning777 gaoning777 deleted the update_kfam_env_variable branch December 11, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

@Bobgy Bobgy

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @Bobgy @IronPan @k8s-ci-robot