Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFMA deployer bug fix #27

Merged
merged 8 commits into from
Nov 5, 2018
Merged

TFMA deployer bug fix #27

merged 8 commits into from
Nov 5, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 3, 2018 •
edited by jlewi
Loading

another bug: bash expr, namespace, etc.

This change is Reviewable

@gaoning777 gaoning777 self-assigned this Nov 3, 2018
@gaoning777
Copy link
Contributor Author

/retest

@gaoning777
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Nov 5, 2018
@google-prow-robot
Copy link
Collaborator

@gaoning777: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
mlpipeline-presubmit-sample-test 87f8840 link /test mlpipeline-presubmit-sample-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qimingj
Copy link
Contributor

qimingj commented Nov 5, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qimingj
Copy link
Contributor

qimingj commented Nov 5, 2018

/LGTM

@qimingj qimingj merged commit 414a5af into master Nov 5, 2018
ojarjur
ojarjur reviewed Nov 5, 2018
View reviewed changes
Copy link

@ojarjur ojarjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .cloudbuild.yaml and .release.cloudbuild.yaml files will need to be updated to account for the name change of the sample.

@gaoning777
Copy link
Contributor Author

Nice catch.
will update that in #67.

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi
Taking junit results into account when computing prow job status. (ku…
be7d554 
…beflow#38)

When decided whether to mark a prow job as failed or succeded we need
to explicitly look at the junit files and determine that.

Prow won't do this automatically.

Fix kubeflow#27
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@gyliu513 @k8s-ci-robot
Removed bin from repo. (kubeflow#27)
5f12420 
It was already exclueded from .gitignore, we should remove it
from repo.
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
@ckadner
Task output parameters as input for subsequent tasks (#27)
9ff9467 
Closes #19
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request May 10, 2024
@openshift-merge-bot
Merge pull request kubeflow#27 from HumairAK/RHOAIENG-4450
2ccfe35 
fix: handle cached input in objstore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojarjur ojarjur ojarjur left review comments

@qimingj qimingj qimingj approved these changes

@vicaire vicaire Awaiting requested review from vicaire

@kubeflow-pipeline-bot kubeflow-pipeline-bot Awaiting requested review from kubeflow-pipeline-bot

@jlewi jlewi Awaiting requested review from jlewi

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@gaoning777 gaoning777

@qimingj qimingj

Labels
approved lgtm priority/p0 size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaoning777 @google-prow-robot @qimingj @k8s-ci-robot @ojarjur @paveldournov