Components - De-hardcoded the UI metadata file path in GCP components #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
numerology
reviewed
Dec 5, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
numerology
pushed a commit
to numerology/pipelines
that referenced
this pull request
Dec 19, 2019
…mponents (kubeflow#2697)" This reverts commit 08ebd15
numerology
pushed a commit
to numerology/pipelines
that referenced
this pull request
Dec 19, 2019
…n GCP components (kubeflow#2697)"" This reverts commit e9bdbd2
k8s-ci-robot
pushed a commit
that referenced
this pull request
Dec 20, 2019
* Revert "Components - De-hardcoded the UI metadata file path in GCP components (#2697)" This reverts commit 08ebd15 * Revert "Revert "Components - De-hardcoded the UI metadata file path in GCP components (#2697)"" This reverts commit e9bdbd2 * provide a default ui json path * lint * test image * revert image tag * update * fix * update image tag * patch 2697 * fix test * fix
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…mponents (kubeflow#2697)" (kubeflow#2759) This reverts commit 08ebd15
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Revert "Components - De-hardcoded the UI metadata file path in GCP components (kubeflow#2697)" This reverts commit 08ebd15 * Revert "Revert "Components - De-hardcoded the UI metadata file path in GCP components (kubeflow#2697)"" This reverts commit e9bdbd2 * provide a default ui json path * lint * test image * revert image tag * update * fix * update image tag * patch 2697 * fix test * fix
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Fix * clean up
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…2697) * Updating Knative Serving and Istio to their latest version Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update version to 0.10.1 Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort to de-hardcode all output paths in the components which is problematie for portability.
This change is