Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build and coveralls badges #267

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Fix build and coveralls badges #267

merged 2 commits into from
Nov 15, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 15, 2018 •
edited
Loading

Use the master branch for coveralls, and travis-ci.org for build badge.

This change is Reviewable

@rileyjbauer
Copy link
Contributor

/lgtm
/approve

@coveralls
Copy link

Pull Request Test Coverage Report for Build 344

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.993%
Totals Coverage Status
Change from base Build 340: 0.0%
Covered Lines: 1704
Relevant Lines: 2192
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 355

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.993%
Totals Coverage Status
Change from base Build 340: 0.0%
Covered Lines: 1704
Relevant Lines: 2192
💛 - Coveralls

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 15, 2018

The number is a bit small...

@yebrahim
Copy link
Contributor Author

/test presubmit-e2e-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 15, 2018
@yebrahim yebrahim changed the title Use master branch for coveralls badge Fix build and coveralls badges Nov 15, 2018
@vicaire
Copy link
Contributor

vicaire commented Nov 15, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer, vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer, vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d606b39 into master Nov 15, 2018
@yebrahim yebrahim deleted the yebrahim/patch-1 branch November 15, 2018 22:07
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@jinchihe @k8s-ci-robot
fix some typos (kubeflow#267)
c1f5194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@vicaire vicaire

@rileyjbauer rileyjbauer

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yebrahim @rileyjbauer @coveralls @Ark-kun @vicaire @k8s-ci-robot