Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Trim pipeline upload url before sending to backend #2630

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 20, 2019

Mitigates #2596

/assign @rmgogogo


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 20, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1b8daf7 into kubeflow:master Nov 20, 2019
@Bobgy Bobgy deleted the ui_trim_file_url branch November 20, 2019 08:08
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Dan Sun <dsun20@bloomberg.net>

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants