create secret for default service account #262
Conversation
IronPan
changed the title
Pull Request Test Coverage Report for Build 361
💛 - Coveralls |
ml-pipeline/Dockerfile
Outdated
| RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl | ||
| RUN chmod +x ./kubectl | ||
| RUN mv kubectl /usr/local/bin/ | ||
|
|
||
| # Install ksonnet | ||
| RUN curl -LO https://github.com/ksonnet/ksonnet/releases/download/v0.11.0/ks_0.11.0_linux_amd64.tar.gz |
There was a problem hiding this comment.
it will be nicer if the version of ksonnet is defined as an ARG variable, it will make it easier to update and test diff versions of it
i.e
ARG KS_VERSION="0.11.0"
RUN curl -LO https://github.com/ksonnet/ksonnet/releases/download/v$KS_VERSION/ks_$KS_VERSION_linux_amd64.tar.gz```
|
/retest |
|
/test build-image |
IronPan
changed the title
|
/assign @Ark-kun |
|
/lgtm |
|
/test presubmit-e2e-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nto yangpa/usersa
|
/test presubmit-e2e-test |
|
/lgtm |
|
/retest |
|
/test presubmit-e2e-test |
|
/retest |
* Use Cloud FileStore for the NFS share * Add a DM config to create cloud filestore instance * Refactor the test_infra directory to have spearate directories for the ksonnet app and deployment manager configs. * Fix kubeflow#262 * Fix jsonet formatting.
* Add Dockerfile and GCB for pushing to GCR * Fix typo in cloudbuild command
* update tekton api client to 0.15 * update doc versioning * Update tekton_kfp_guide.md
This is for smooth transition to kubeflow deployment. Kubeflow would have this installed in cluster and our components start to rely on its existence.
This change is