Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inverse proxy agent in e2e tests #2566

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix inverse proxy agent in e2e tests #2566

merged 1 commit into from
Nov 7, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 7, 2019 •
edited
Loading

Even in a successful test, we can see inverse proxy is in ImagePullBackOff state. It's not used in any e2e tests, so it doesn't break presubmit.
example log: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/2563/kubeflow-pipeline-e2e-test/1192300433008234496#1:build-log.txt%3A1426

However, this issue breaks image caching. Inverse proxy agent is always not in gcr because we didn't push it there. This PR fixes the issue.

Benefit of the fix: rerunning tests will skip the image building step.

/assign @jingzhang36

This change is Reviewable

Bobgy
Bobgy commented Nov 7, 2019
View reviewed changes
test/cloudbuild/batch_build.yaml
- "$_GCR_BASE/viewer-crd-controller"
- "$_GCR_BASE/visualization-server"
- "$_GCR_BASE/inverse-proxy-agent"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images put here will be pushed to gcr, inverse proxy agent was built but forgot to be pushed

@numerology
Copy link

/lgtm

@Bobgy Bobgy mentioned this pull request Nov 7, 2019
Merged
@jingzhang36
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f18ed7 into kubeflow:master Nov 7, 2019
@Bobgy Bobgy deleted the fix_inverse_proxy_in_e2e_tests branch November 7, 2019 07:53
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

This doesn't fully fix the issue. inverse-proxy-agent is now in CrashLoopBackOff instead.
I checked, error message is /bin/sh: 1: /opt/proxy/attempt-register-vm-on-proxy.sh: not found
It seems something went wrong building the image. I'm going to investigate.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Follow up fix: #2568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@jingzhang36 jingzhang36

@numerology numerology

Labels
approved area/testing kind/bug lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bobgy @numerology @jingzhang36 @k8s-ci-robot