Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin tensorboard version to 1.13.2 #2513

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Pin tensorboard version to 1.13.2 #2513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41596f7
Pin tensorboard version to 1.13.2
IronPan Oct 30, 2019
7237753
Update reconciler.go
IronPan Oct 30, 2019
3df4bd9
Update reconciler.go
IronPan Oct 30, 2019
d24ec5b
Update reconciler_test.go
IronPan Oct 30, 2019
80fb111
Update reconciler_test.go
IronPan Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backend/src/crd/controller/viewer/reconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,14 @@ func setPodSpecForTensorboard(view *viewerV1beta1.Viewer, s *corev1.PodSpec) {

c := &s.Containers[0]
c.Name = view.Name + "-pod"
c.Image = "tensorflow/tensorflow"
c.Image = "tensorflow/tensorflow:1.13.2"
c.Args = []string{
"tensorboard",
fmt.Sprintf("--logdir=%s", view.Spec.TensorboardSpec.LogDir),
fmt.Sprintf("--path_prefix=/tensorboard/%s/", view.Name),
"--bind_all",
// This is needed for tf 2.0. We need to optionally add it
// when https://github.com/kubeflow/pipelines/issues/2514 is done
// "--bind_all",
}
c.Ports = []corev1.ContainerPort{
corev1.ContainerPort{ContainerPort: viewerTargetPort},
Expand Down
10 changes: 4 additions & 6 deletions backend/src/crd/controller/viewer/reconciler/reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,11 @@ func TestReconcile_EachViewerCreatesADeployment(t *testing.T) {
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "viewer-123-pod",
Image: "tensorflow/tensorflow",
Image: "tensorflow/tensorflow:1.13.2",
Args: []string{
"tensorboard",
"--logdir=gs://tensorboard/logdir",
"--path_prefix=/tensorboard/viewer-123/",
"--bind_all"},
"--path_prefix=/tensorboard/viewer-123/"},
Ports: []corev1.ContainerPort{{ContainerPort: 6006}},
}}}}}}}

Expand Down Expand Up @@ -272,12 +271,11 @@ func TestReconcile_ViewerUsesSpecifiedVolumeMountsForDeployment(t *testing.T) {
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "viewer-123-pod",
Image: "tensorflow/tensorflow",
Image: "tensorflow/tensorflow:1.13.2",
Args: []string{
"tensorboard",
"--logdir=gs://tensorboard/logdir",
"--path_prefix=/tensorboard/viewer-123/",
"--bind_all"},
"--path_prefix=/tensorboard/viewer-123/"},
Ports: []corev1.ContainerPort{{ContainerPort: 6006}},
VolumeMounts: []v1.VolumeMount{
{Name: "/volume-mount-name", MountPath: "/mount/path"},
Expand Down