Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Enlarge choose pipeline dialog to show more description #2494

Merged
merged 4 commits into from
Oct 25, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Oct 25, 2019

Fixes #154

changes:

  • added mock data with a pipeline description in markdown
  • Fixed typo: Description
  • changed description to markdown
  • changed dialog styling to make it wider

for actual code change avoiding formatting issues, read this link

screenshot:
download (20)

/assign @rmgogogo
/area front-end


This change is Reviewable

@rmgogogo
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 25, 2019

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 26a244d into kubeflow:master Oct 25, 2019
@Bobgy Bobgy deleted the fe_choose_pipeline_description branch October 25, 2019 14:34
@Bobgy Bobgy changed the title Enlarge choose pipeline dialog to show more description [Frontend] Enlarge choose pipeline dialog to show more description Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't read full text in "Choose a pipeline" dialog
3 participants