Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline description 255 characters length limit #2492

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix pipeline description 255 characters length limit #2492

merged 2 commits into from
Oct 25, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Oct 25, 2019 •
edited
Loading

Fixes #2485

Note: migration step learned from existing one:

pipelines/backend/src/apiserver/client_manager.go

Line 207 in 7aaecb1

response = db.Model(&model.ResourceReference{}).ModifyColumn("Payload", "longtext")

/cc @jingzhang36
/assign @IronPan

This change is Reviewable

@Bobgy Bobgy added kind/bug and removed size/XS labels Oct 25, 2019
@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

/lgtm
/approve

@jingzhang36
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 25, 2019

/hold
because I am seeing the column becomes nullable
troubleshooting the issue

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 25, 2019
@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingzhang36
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 25, 2019

/hold cancel
Verified now columns are not null.

Note: also fixed resource_reference field's payload became nullable bug in this PR

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 25, 2019

Verified manually this works and is backward-compatible.

Scenario 1 (upgrading from an existing cluster):

  1. Change backend image to new image.
  2. Verified now description column is longtext
  3. Verified UI works with backend
  4. Verified uploading a new pipeline doesn't cause exceptions

Scenario 2 (creating a cluster):

  1. Changed ml-pipeline api server's replica to 0
  2. Dropped mlpipeline db in mysql
  3. Changed ml-pipeline api server's replica back to 1
  4. Now samples are loaded again, and I verified their description is complete

@k8s-ci-robot k8s-ci-robot merged commit 572a305 into kubeflow:master Oct 25, 2019
@Bobgy Bobgy deleted the be_fix_description_length branch October 25, 2019 09:11
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Update KServe generated client code (kubeflow#2492)
ce000db 
* Update KServe generated client code

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Remove predictor/transformer config tests

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

Assignees

@IronPan IronPan

@jingzhang36 jingzhang36

Labels
approved area/backend kind/bug lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline description not fully shown in UI
4 participants
@Bobgy @IronPan @jingzhang36 @k8s-ci-robot