Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] change deployment platform to gcp #248

Closed
wants to merge 3 commits into from
Closed

[WIP] change deployment platform to gcp #248

wants to merge 3 commits into from

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 14, 2018 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ironpan

If they are not already assigned, you can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ironpan

If they are not already assigned, you can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Nov 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 345

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193
💛 - Coveralls

@IronPan IronPan closed this Nov 14, 2018
@IronPan IronPan deleted the IronPan-patch-4 branch December 10, 2018 22:26
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@jc2729 @k8s-ci-robot
More TF2OpenAPI Unit Tests (kubeflow#248)
3107cdf 
* Test with real models

* Resolve non-determinism in array matching

* Make OpenAPI restrictions more strict

* disallow additional properties in req body that aren't specified in
OpenAPI

* Update unit tests to be more restrictive

* Add generator unit test

* Add generator tests

* Add JSON extension to spec files for highlighting

* Move utils to kfserving utils

* Fix formatting

* Organize utils types into separate file
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@fenglixa
An easy solution of archiving pipeline logs to S3 (kubeflow#248)
819e4ed 
* update code to address the review comments

* change the dir name

* change the dir name

* update yaml file after rebase master

* update yaml file to trigger travic

* address comments from Tommy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicaire vicaire Awaiting requested review from vicaire

Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IronPan @k8s-ci-robot @coveralls