Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Update pre-load TFX::OSS sample #2476

Merged
merged 5 commits into from
Oct 24, 2019
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/apiserver/config/sample_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"file": "/samples/core/exit_handler/exit_handler.py.tar.gz"
},
{
"name": "[Sample] ML - TFX - Taxi Tip Prediction Model Trainer",
"name": "[Sample] Unified DSL - Taxi Tip Prediction Model Trainer",
IronPan marked this conversation as resolved.
Show resolved Hide resolved
"description": "[GCP Permission requirements](https://github.com/kubeflow/pipelines/blob/master/samples/contrib/parameterized_tfx_oss#permission). Example pipeline that does classification with model analysis based on a public tax cab BigQuery dataset. [source code](https://github.com/kubeflow/pipelines/tree/master/samples/contrib/parameterized_tfx_oss)",
"file": "/samples/contrib/parameterized_tfx_oss/parameterized_tfx_oss.tar.gz"
}
Expand Down
12 changes: 7 additions & 5 deletions samples/contrib/parameterized_tfx_oss/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ This sample demonstrates how to author a ML pipeline in TFX and run it on a KFP
Please refer to inline comments for the purpose of each step.

In order to successfully compile this sample, you'll need to have a TFX installation at HEAD.
First, you can clone their repo and
then point the version tag in `tfx/version.py` to TFX's latest nightly build image of version
`0.15.0dev` (e.g., `0.15.0dev20191007`, list of image available can be found [here](https://hub.docker.com/r/tensorflow/tfx/tags)).
Finally, run `python setup.py install` from `tfx/tfx`. After that, running
`chicago_taxi_pipeline_simple.py` compiles the TFX pipeline into KFP pipeline package.
First, you can clone their repo and run `python setup.py install` from `tfx/tfx`.
The image used in the pipeline is specified as `tfx_image` in the
`KubeflowDagRunnerConfig`. Currently we're using our own patched version of TFX image containing visualization support.
List of officially released nightly build image available can be found [here](https://hub.docker.com/r/tensorflow/tfx/tags)).

After that, running
`python3 chicago_taxi_pipeline_simple.py` compiles the TFX pipeline into KFP pipeline package.
This pipeline requires google storage permission to run.


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ def _get_kubeflow_metadata_config() -> kubeflow_pb2.KubeflowMetadataConfig:
enable_cache=enable_cache)

config = kubeflow_dag_runner.KubeflowDagRunnerConfig(
kubeflow_metadata_config=_get_kubeflow_metadata_config())
kubeflow_metadata_config=_get_kubeflow_metadata_config(),
tfx_image='gcr.io/ml-pipeline/patched-tfx:0.1.32')

kfp_runner = kubeflow_dag_runner.KubeflowDagRunner(config=config)
# Make sure kfp_runner recognizes those parameters.
Expand Down
Binary file modified samples/contrib/parameterized_tfx_oss/parameterized_tfx_oss.tar.gz
Binary file not shown.