SDK - Python components - Fixed bug when mixing file outputs with return value outputs #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn value outputs
Ark-kun
requested review from
numerology and
SinaChavoshi
and removed request for
gaoning777 and
hongye-sun
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…provided uri is not a folder (kubeflow#3088) * fix issue kubeflow#2473 Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * add test Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * flake8 Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * update target_key logic and add test Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * update Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Implemented to download exact s3 object. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixed s3 storage test. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Refactor code to make it more readable and reduce cognitive complexity Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is