Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string literals for reference resource relation and for reference resource type in frontend #2453

Merged
merged 10 commits into from
Oct 23, 2019

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Oct 22, 2019

Use string literals for reference resource relationship and for reference resource type in frontend.
For bug #2430


This change is Reviewable

@jingzhang36
Copy link
Contributor Author

jingzhang36 commented Oct 22, 2019

@Bobgy and @IronPan for frontend changes.

@jingzhang36 jingzhang36 changed the title Use explicit string literals in places for reference resource relation and for reference resource type Use string literals for reference resource relation and for reference resource type in frontend Oct 22, 2019
@jingzhang36 jingzhang36 requested review from IronPan and removed request for Ark-kun October 22, 2019 03:45
@Bobgy
Copy link
Contributor

Bobgy commented Oct 22, 2019

Side note:
For cast in typescript enums, I found there's a PR fixing it for swagger: swagger-api/swagger-codegen#7914, but no one is working on it.
Author mentioned the PR is merged in a fork of swagger-codegen: OpenAPITools/openapi-generator#145

openapi-generator is compatible with swagger-codegen 2.4.0, so it may be an option too. I feel there could be a lot of efforts figuring out what we want to choose from. Just noting these discoveries first.

@Bobgy
Copy link
Contributor

Bobgy commented Oct 22, 2019

Oops, I reformatted frontend/src/apis
Which part of it is auto generated code?

@Bobgy
Copy link
Contributor

Bobgy commented Oct 23, 2019

Thanks for the fix!
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6ec7eca into kubeflow:master Oct 23, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* remove pytorchserver dead code

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

* remove pytorch makefile commands - they dont work

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants