Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the GO import paths to reference the kubeflow/pipelines repository #24

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Nov 2, 2018

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vicaire

If they are not already assigned, you can assign the PR to them by writing /assign @vicaire in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire merged commit 6e8bae3 into master Nov 2, 2018
@google-prow-robot
Copy link
Collaborator

@vicaire: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
mlpipeline-build-image 1bab424 link /test mlpipeline-build-image
mlpipeline-presubmit-unit-test 1bab424 link /test mlpipeline-presubmit-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…row jobs. (kubeflow#25)

Currently each repository needs to build a new Docker container. The sole purpose of this container is to specify the path to the Argo workflow to run.

We can simplify this by just allowing each repository to define a "prow_config.yaml" file at the root of the repository and then having a single binary which will read that config file and use it to figure out which workflows to invoke

This fixes kubeflow#24

We also add support for running multiple workflows.

This will make it easy to start using prow to build our containers on each commit (kubeflow#19)
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Ce Gao <gaoce@caicloud.io>
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants