[Sample] Add back visualization in XGBoost sample #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
September 18, 2019 17:47
…enew-xgboost-sample # Conflicts: # samples/core/xgboost_training_cm/xgboost_training_cm.py
…enew-xgboost-sample
…enew-xgboost-sample # Conflicts: # samples/core/xgboost_training_cm/xgboost_training_cm.py
…enew-xgboost-sample
…dd-back-visualization-based-on-xgb # Conflicts: # samples/core/xgboost_training_cm/xgboost_training_cm.py # test/sample-test/run_sample_test.py
numerology
changed the title
|
/hold cancel |
|
/retest |
gaoning777
reviewed
Oct 16, 2019
|
/retest |
|
Have you manually run the sample and checked the confusion matrix and roc was rendered correctly? |
|
Yes I did. |
Great, thanks |
added 3 commits
October 15, 2019 22:44
This reverts commit 81ba446
…dd-back-visualization-based-on-xgb
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.ca> Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion re: #2177 , new GCP components do not support visualization well due to the lack of custom output. However, for XGBoost sample particularly, we can have a workaround by setting the related data path manually.
TODO:
This change is