Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Improve tfx oss sample #2360

Merged
merged 8 commits into from
Oct 11, 2019

Conversation

numerology
Copy link

@numerology numerology commented Oct 10, 2019

Did two things here:

Fixes #2354


This change is Reviewable

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

3 similar comments
@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

2 similar comments
@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

self._test_args['pipeline-root'] = os.path.join(self._test_args['output'], 'tfx_taxi_simple')
self._test_args['pipeline-root'] = os.path.join(
self._test_args['output'],
'tfx_taxi_simple_' + str(int(time.time())))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also use the kfp.dsl.RUN_ID_PLACEHOLDER.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I think that's better

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ark-kun Done.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 11, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 11, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 19db87d into kubeflow:master Oct 11, 2019
@numerology numerology deleted the improve-tfx-oss-sample branch October 11, 2019 20:15
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Pass request headers to predict method (kubeflow#2284)

* Pass inference request headers to model's predict method

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Fixed liniting error

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Added changes for passing headers in explainer

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Changes for explainer and changed field name to payload from request

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Fixed import errors and added header in preprocess

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* pass-headers-debug

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Added container logs in status check.
Changed function signature hints.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Reverted import re-ordering

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Updated param order hint
Made changes to copy only request id and trace id

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfx-oss sample test would fail when retry the test
4 participants