Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move basic sample tests to e2e tests #235

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 13, 2018

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 332

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%

Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 13, 2018

Pull Request Test Coverage Report for Build 302

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%

Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193

💛 - Coveralls

@gaoning777 gaoning777 changed the title [WIP] move basic sample tests to e2e tests Move basic sample tests to e2e tests Nov 13, 2018
@gaoning777 gaoning777 requested a review from yebrahim November 13, 2018 21:43
Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm on the frontend integration test change.

@IronPan
Copy link
Member

IronPan commented Nov 14, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 790cb36 into master Nov 14, 2018
@gaoning777 gaoning777 deleted the ngao/basic-sample-test branch November 14, 2018 21:52
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
… available (kubeflow#235)

* Add instructions for debugging tests where the container status isn't available.

* Fix typo.

* Add TOC.

* Address comments.
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
* Tolerate erratic log lines in E2E tests
* Add option to re-run only tests that failed previously
* Add option to exclude/include certain test_cases only
* Add volume_op.yaml to ignored tests as the created PVC
  needs to be deleted before/after test run
* Regenerate "golden" log files after recent commits
  changed the log output regarding artifacts
* Add option to override expected Tekton Pipeline and CLI
  versions, default: 0.14 and 0.10

Closes #229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants