Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK/Compiler] Add _create_and_write_workflow method #2321

Merged

Conversation

numerology
Copy link

@numerology numerology commented Oct 7, 2019

This is a follow up change of #2146

This change allows user to directly compile a pipeline function into a supported format, while specifying things like pipeline configuration and pipeline parameters.
Also, _compile should be marked as deprecated in favor of _create_workflow in near future, for they have identical functions.


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 7, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 092845d into kubeflow:master Oct 7, 2019
@numerology numerology deleted the sdk-compiler-add-create-and-write branch October 9, 2019 19:33
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants