Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components - Reorganized components/kubeflow #232

Merged
merged 3 commits into from
Nov 16, 2018
Merged

Components - Reorganized components/kubeflow #232

merged 3 commits into from
Nov 16, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 13, 2018 •
edited by jlewi
Loading

Component directories should be self-contained.

New directory structure:

components
  component_group
    component_name
      src/*
      tests/*
      Dockerfile
      build_image.sh

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 13, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 285

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193
💛 - Coveralls

@Ark-kun Ark-kun mentioned this pull request Nov 14, 2018
Merged
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 14, 2018

@gaoning777 asked me to try a local cloud build. I should do it.

@Ark-kun Ark-kun force-pushed the avolkov/Reorganized-components/kubeflow branch from 98dba68 to fdb2fea Compare November 15, 2018 23:52
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

I've run local cloudbuild successfully.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 16, 2018

/test build-image

gaoning777
gaoning777 approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 16, 2018

/approve

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 16, 2018

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 16, 2018

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 16, 2018

@IronPan Can you please check and approve this change?

@IronPan
Copy link
Member

IronPan commented Nov 16, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e6b4107 into master Nov 16, 2018
@Ark-kun Ark-kun deleted the avolkov/Reorganized-components/kubeflow branch November 28, 2018 17:37
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi @k8s-ci-robot
Fix label 0.4.0 (kubeflow#232)
bfeaaf5 
* The indentation in kubeflow_label.yml was messed up so the 0.4.0
  tag wasn't being included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@ojarjur ojarjur Awaiting requested review from ojarjur

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@IronPan IronPan

@gaoning777 gaoning777

@qimingj qimingj

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ark-kun @coveralls @IronPan @k8s-ci-robot @gaoning777 @qimingj