Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Added the ComponentSpec.save method #2264

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 29, 2019

This change is Reviewable

@numerology
Copy link

I think it would be better if a unittest is added.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 3, 2019

I think it would be better if a unittest is added.

I think this code path is tested by the following unit tests:

def test_func_to_container_op_output_component_file(self):

def test_func_to_component_file(self):

def test_end_to_end_python_component_pipeline_compilation(self):

This PR just extracts/moves the code.

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 3, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b2f1d00 into kubeflow:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants