Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc for MKP release #2242

Merged
merged 8 commits into from
Oct 1, 2019
Merged

Update doc for MKP release #2242

merged 8 commits into from
Oct 1, 2019

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Sep 26, 2019 •
edited by jlewi
Loading

This change is Reviewable

rmgogogo
rmgogogo commented Sep 26, 2019
View reviewed changes
manifests/gcp_marketplace/schema.yaml
@@ -104,15 +104,11 @@ properties:
title: |-
GCP Service Account credentials used to call other GCP services.
description: |-
To be able to call other GCP services from the pipeline, we need to be authenticated.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested by ccarpentiere
6b6b83c#diff-7012a5457da64b7262de5880ef600e46

@rmgogogo
Copy link
Contributor Author

Thanks James. Updated.

ccarpentiere
ccarpentiere reviewed Sep 26, 2019
View reviewed changes
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
@rmgogogo
Copy link
Contributor Author

updated doc and enable pwd masking

@james-jwu
Copy link
Contributor

/lgtm

@james-jwu
Copy link
Contributor

/approve

@james-jwu
Copy link
Contributor

/assign @neuromage

@neuromage
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: james-jwu, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4b12720 into kubeflow:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccarpentiere ccarpentiere ccarpentiere left review comments

@james-jwu james-jwu james-jwu left review comments

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@neuromage neuromage

@james-jwu james-jwu

Labels
approved area/deployment/marketplace lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rmgogogo @james-jwu @neuromage @k8s-ci-robot @ccarpentiere @Ark-kun