Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Fixed serialization of lists and dicts containing PipelineParam items #2212

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 24, 2019

Fixes #2206
The issue is fixed for both JSON-based and str()-based serialization.


This change is Reviewable

…`PipelineParam` items

Fixes kubeflow#2206
The issue is fixed for both `JSON`-based and `str()`-based serialization.
@numerology
Copy link

Thanks @Ark-kun !

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PipelineParams that are part of a complex argument object are not serialized properly
6 participants