SDK - Moved the _container_builder from kfp.compiler to kfp.containers #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
force-pushed
the
SDK---Moved-the-_container_builder-from-kfp.compiler-to-kfp.containers
branch
2 times, most recently
from
ae60bc7
to
52d41cf
Compare
|
/lgtm |
This only moves the files. The imports remain the same for now.
Ark-kun
force-pushed
the
SDK---Moved-the-_container_builder-from-kfp.compiler-to-kfp.containers
branch
from
52d41cf
to
18f8fb1
Compare
|
Fixed the merge conflicts. |
|
/test kubeflow-pipeline-sample-test |
|
/lgtm But it seems like the CLA is problematic, might because merged with commits from other people? |
|
@googlebot I fixed it. |
Looks like the bot just got stuck for some reason. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only moves the files. The imports remain the same for now.
This change is