Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the backend Go module cache to .gitignote #2190

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 23, 2019

This change is Reviewable

@neuromage
Copy link
Contributor

Does go build create this directory?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 11, 2019

Does go build create this directory?

I think it's somehow related to some new Go modules utilities.
Something like gomod (I do not know exactly which program) used by the VS Code started downloading thousands of files there.

@IronPan
Copy link
Member

IronPan commented Oct 15, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 17, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit ac5a04a into kubeflow:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants