Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build inverse proxy image as part of the presubmit test #2187

Merged
merged 9 commits into from
Sep 21, 2019
Merged

Build inverse proxy image as part of the presubmit test #2187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ea579fc
small fixes
IronPan Sep 17, 2019
4331f93
small fixes
IronPan Sep 17, 2019
6baa768
Merge remote-tracking branch 'upstream/master'
IronPan Sep 17, 2019
f244388
Merge remote-tracking branch 'upstream/master'
IronPan Sep 18, 2019
d040dc3
Merge remote-tracking branch 'upstream/master'
IronPan Sep 19, 2019
9f4ad5b
Merge remote-tracking branch 'upstream/master'
IronPan Sep 20, 2019
8b8cafe
Merge remote-tracking branch 'upstream/master'
IronPan Sep 21, 2019
7a83e33
add
IronPan Sep 21, 2019
2ba5d93
Delete Makefile
IronPan Sep 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/build-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ if
echo "$BUILT_IMAGES" | grep scheduledworkflow && \
echo "$BUILT_IMAGES" | grep persistenceagent && \
echo "$BUILT_IMAGES" | grep viewer-crd-controller && \
echo "$BUILT_IMAGES" | grep inverse-proxy-agent && \
echo "$BUILT_IMAGES" | grep visualization-server;
then
echo "docker images for api-server, frontend, scheduledworkflow, \
persistenceagent, viewer-crd-controller, and visualization-server \
persistenceagent, viewer-crd-controller, inverse-proxy-agent, and visualization-server \
are already built in ${GCR_IMAGE_BASE_DIR}."
else
echo "submitting cloud build to build docker images for commit ${PULL_PULL_SHA}..."
Expand Down
4 changes: 4 additions & 0 deletions test/cloudbuild/batch_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ steps:
args:
["build", "-t", "$_GCR_BASE/visualization-server", "-f", "backend/Dockerfile.visualization", "."]
waitFor: ["-"]
- name: "gcr.io/cloud-builders/docker"
args:
["build", "-t", "$_GCR_BASE/inverse-proxy-agent", "-f", "proxy/Dockerfile", "."]
waitFor: ["-"]
options:
machineType: N1_HIGHCPU_8 # use a fast machine to build because there a lot of work
images:
Expand Down
1 change: 1 addition & 0 deletions test/deploy-pipeline-lite.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ kustomize edit set image gcr.io/ml-pipeline/scheduledworkflow=${GCR_IMAGE_BASE_D
kustomize edit set image gcr.io/ml-pipeline/frontend=${GCR_IMAGE_BASE_DIR}/frontend:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/viewer-crd-controller=${GCR_IMAGE_BASE_DIR}/viewer-crd-controller:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/visualization-server=${GCR_IMAGE_BASE_DIR}/visualization-server:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/inverse-proxy-agent=${GCR_IMAGE_BASE_DIR}/inverse-proxy-agent:${GCR_IMAGE_TAG}
cat kustomization.yaml

kustomize build . | kubectl apply -f -
Expand Down