Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing - Output Argo workflow information when the workflow times out #2176

Merged
merged 6 commits into from
Sep 23, 2019
Merged

Testing - Output Argo workflow information when the workflow times out #2176

merged 6 commits into from
Sep 23, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 19, 2019 •
edited
Loading

Otherwise the workflows are hard to debug.

Also log child workflows on all failures.

This change is Reviewable

@numerology
Copy link

/lgtm

Bobgy
Bobgy reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a helpful change.

Left some comments. @Ark-kun can you take a look?

test/check-argo-status.sh Outdated Show resolved Hide resolved
test/check-argo-status.sh Outdated Show resolved Hide resolved
test/check-argo-status.sh Outdated Show resolved Hide resolved
test/check-argo-status.sh Outdated Show resolved Hide resolved
test/check-argo-status.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 20, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 21, 2019

@Bobgy Can you please re-LGTM and approve?

Bobgy
Bobgy approved these changes Sep 21, 2019
View reviewed changes
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ark-kun sorry, there are two minor issues I overlooked last time, can you double check?

I think this is good enough. You can ask anyone to LGTM when you finish the fix.

/approve

test/check-argo-status.sh Outdated Show resolved Hide resolved
test/check-argo-status.sh Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun requested a review from Bobgy September 23, 2019 19:15
@Bobgy
Copy link
Contributor

Bobgy commented Sep 23, 2019

Thanks for the change!
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 7dab300 into kubeflow:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy approved these changes

@IronPan IronPan Awaiting requested review from IronPan

@numerology numerology Awaiting requested review from numerology

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@IronPan IronPan

@Bobgy Bobgy

@numerology numerology

Labels
approved area/testing lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ark-kun @numerology @k8s-ci-robot @Bobgy @IronPan