Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes #217

Merged
merged 2 commits into from
Nov 13, 2018
Merged

minor fixes #217

merged 2 commits into from
Nov 13, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 12, 2018 •
edited by jlewi
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 12, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 259

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.506%
Totals Coverage Status
Change from base Build 225: 0.0%
Covered Lines: 1535
Relevant Lines: 2182
💛 - Coveralls

@gaoning777 gaoning777 self-assigned this Nov 12, 2018
@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b744057 into master Nov 13, 2018
@gaoning777 gaoning777 deleted the ngao/python-sdk-unittest branch November 13, 2018 02:13
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@lluunn @k8s-ci-robot
Add log for why triggering a workflow (kubeflow#217)
a8b22fd 
* add log

* fix
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@fenglixa
Update the samples of big data since the design changed (kubeflow#217)
3f676af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun approved these changes

@IronPan IronPan Awaiting requested review from IronPan

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @coveralls @k8s-ci-robot @Ark-kun