Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Fixed the output types for outputs with converted names #2162

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 18, 2019

Fixes #2130


This change is Reviewable

@numerology
Copy link

/lgtm

@Ark-kun Ark-kun force-pushed the SDK---Components---Fixed-the-output-types-for-outputs-with-converted-names branch from a3e44a6 to fa8630e Compare September 18, 2019 19:44
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 18, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 18, 2019

/retest

@Ark-kun Ark-kun force-pushed the SDK---Components---Fixed-the-output-types-for-outputs-with-converted-names branch from fa8630e to 3dea33d Compare September 18, 2019 21:35
@Ark-kun Ark-kun force-pushed the SDK---Components---Fixed-the-output-types-for-outputs-with-converted-names branch from 3dea33d to 1d2f946 Compare September 18, 2019 21:48
@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e420940 into kubeflow:master Sep 19, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type checking is enforced when output names are not with underscore
5 participants