Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: should pop-up a correct info when delete more than one pipeline #2156

Merged
merged 1 commit into from
Oct 15, 2019
Merged

GUI: should pop-up a correct info when delete more than one pipeline #2156

merged 1 commit into from
Oct 15, 2019

Conversation

QxiaoQ
Copy link
Contributor

@QxiaoQ QxiaoQ commented Sep 18, 2019

When user select and delete more than one pipeline, the confirmation info should be changed.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @QxiaoQ. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QxiaoQ QxiaoQ changed the title Fix issue when user selected more than one pipeline GUI: should pop-up a correct info when delete more than one pipeline Sep 18, 2019
@QxiaoQ
Copy link
Contributor Author

QxiaoQ commented Sep 18, 2019

@jinchihe

@jinchihe
Copy link
Member

/ok-to-test

@QxiaoQ
Copy link
Contributor Author

QxiaoQ commented Sep 19, 2019

/area front-end

@jinchihe
Copy link
Member

/lgtm

@Bobgy
Copy link
Contributor

Bobgy commented Oct 15, 2019

Thanks
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0bde90d into kubeflow:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants