[Test/sample_test] Fix arguments parsing in yaml config. #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gaoning777
reviewed
Sep 17, 2019
| @@ -100,7 +100,8 @@ def run(self): | |||
| except OSError as ose: | |||
| print('Config file with the same name not found, use default args:{}'.format(ose)) | |||
| else: | |||
| self._test_args.update(raw_args['arguments']) | |||
| if raw_args['arguments']: | |||
There was a problem hiding this comment.
this will fail if there is no 'argument'.
There was a problem hiding this comment.
You need to check if arguments exists and check the value is not None
|
/close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip when arguments section is empty.
This problem is blocking #2141
This change is