Update documentations for Kubeflow Pipelines marketplace #2125
Conversation
|
/assign @rmgogogo |
|
Thanks @IronPan! I don't have bandwidth to review this PR at the moment. I'll email you with some suggestions about reviewers. |
| @@ -101,33 +101,59 @@ properties: | |||
| x-google-marketplace: | |||
| type: NAMESPACE | |||
| serviceAccountCredential: | |||
| title: Service Account credentials used to call other GCP services. | |||
| title: |- | |||
| Service Account credentials used to call other GCP services. | |||
There was a problem hiding this comment.
wonding whether we call it "GCP Service Account credentials used ...".
As talked last time, we have two types of service account, one is K8s and other is GCP.
| JSON file. It can be encoded using base64 instead of messing with JSON format. | ||
| To get the encoded credential, run | ||
| $ gcloud iam service-accounts keys create application_default_credentials.json --iam-account [your-service-account] && cat application_default_credentials.json | base64 |
There was a problem hiding this comment.
not sure whether the special characters here '$', '&' will be escaped by MKP UI, we may need to double check it manually after another staging in MKP
There was a problem hiding this comment.
i verified it and should be ok.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This change update the documentations that are visible to the end user when they visiting marketplace page.
/assign @sarahmaddox
This change is