Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfp.dsl.components needed for kubeflow-job #212

Closed
wants to merge 2 commits into from

Conversation

lakshmanok
Copy link
Contributor

@lakshmanok lakshmanok commented Nov 12, 2018

This change is Reviewable

kubeflow_tfjob_launcher_op is in kfp.dsl.components
Allow use of kubeflow_tfjob_launcher_op
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gaoning777

If they are not already assigned, you can assign the PR to them by writing /assign @gaoning777 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @lakshmanok. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @lakshmanok. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 309

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.506%

Totals Coverage Status
Change from base Build 225: 0.0%
Covered Lines: 1535
Relevant Lines: 2182

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 238

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.506%

Totals Coverage Status
Change from base Build 225: 0.0%
Covered Lines: 1535
Relevant Lines: 2182

💛 - Coveralls

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2018

Good catch.
/ok-to-test

We're still experimenting with different component packaging strategies and I'm not sure including any components in the SDK package is a good idea.

This component python factory can also be taken from https://github.com/kubeflow/pipelines/blob/master/components/kubeflow/launcher/kubeflow_tfjob_launcher_op.py which sounds like a more appropriate place for a component.

@k8s-ci-robot
Copy link
Contributor

@lakshmanok: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
presubmit-unit-test 3cf4fea link /test presubmit-unit-test
build-image 3cf4fea link /test build-image
presubmit-e2e-test 3cf4fea link /test presubmit-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 26, 2018

It's been decided to remove this component from the core SDK. See #233

@Ark-kun Ark-kun closed this Nov 26, 2018
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* add support for anonymous azure blobs

* recognize blob paths as valid

* remove obsolete validation

* update pytorch to use initialized path

* add $ on env vars

* use model initializer with tensorrt

* udpate readmez
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants