Add imagepullsecrets sample into sample test #2113
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The secret 'secretA' does not exist in the test infra, does it? |
No it does not. However it doesn't prevent us from running this sample. I guess k8s uses image pull secrets lazily. I put the function call here just to verify whether we can call this function successfully. Ideally it will be great if we can really set up a protected registry and an associated secret in order to pull image from there, but that will be much harder and cumbersome. |
|
If the runtime feature is not verified, maybe we can simply test the compilation without running the pipeline. The extra step of running the pipeline only adds the value of verifying the pipeline will work with a non-existing image secret. |
) Until now KServe was using the global HTTP endpoint for S3 by default unless the user explicitly provides it with the corresponding annotation. If one wants to use IAM roles for service accounts instead of Secrets with HMAC credentials, storage-initializer will fail in case: * the bucket is configured with SSE * if the bucket allows HTTPS requests only * of an airgapped environment Specifically, if the bucket is configured with SSE it fails with: botocore.exceptions.ClientError: An error occurred (InvalidArgument) when calling the GetObject operation: Requests specifying Server Side Encryption with AWS KMS managed keys must be made over a secure connection. If the bucket policy allows HTTPS requests only it fails with: botocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the ListObjects operation: Access Denied In case of an airgapped environment, S3 is only available via the regional VPC endpoint so requests to the global endpoint will hang. Handle the above cases by letting boto3 decide the S3 endpoint based on the environment. In case of IRSA, AWS will set AWS_REGION and AWS_DEFAULT_REGION and as such boto3 will use the regional endpoint. boto3 will use HTTPS by default which is inline with the default value of s3-usehttps annotation. Finally, if the bucket is in different region boto3 will be automatically redirected there. This change should not break existing deployments that don't use IRSA but don't set s3-endpoint either; boto3 will default using the global HTTPS endpoint, https://s3.amazonaws.com. Handle also the case where endpoint_url is unset or empty, where boto3 fails with: ValueError: Invalid endpoint: With this commit, one can use service accounts with the `eks.amazonaws.com/role-arn` and `eks.amazonaws.com/sts-regional-endpoints` annotations directly without the need of an attached secret. Refs kubeflow#2003 Refs kubeflow#2113 Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com> Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com>
Part of #1813
This change is