Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubeflow as default namespace for tf serving #211

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 12, 2018

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 12, 2018

/assign @Ark-kun

@coveralls
Copy link

coveralls commented Nov 12, 2018

Pull Request Test Coverage Report for Build 308

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.506%

Totals Coverage Status
Change from base Build 225: 0.0%
Covered Lines: 1535
Relevant Lines: 2182

💛 - Coveralls

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2018

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Nov 12, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7fc1f0 into master Nov 13, 2018
@IronPan IronPan deleted the IronPan-patch-3 branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…try (kubeflow#211)

* Grant permissions to test service account to push to our public registry.

* This is a temporary solution to improve automation around releasing our
  images by pushing them on postsubmit.

* See
    kubeflow/kubeflow#1574 use prow to auto release images
    kubeflow/kubeflow#816 trigger image pushes on postsubmit.

* GCB service account needs to be able to push to kubeflow-images-public so
that kubeflow-ci can use GCB to push images.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Add hougangliu as a reviewer for kfserving, mainly focus
on kfserving controller and CI test.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* add kfp user-guide

* Apply suggestions from code review

Co-authored-by: Animesh Singh <singhan@us.ibm.com>

* update table of contents

Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants