Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external links that make some content easier to discover #2068

Merged
merged 6 commits into from
Nov 6, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 9, 2019

/assign @rmgogogo
/assign @IronPan

Idea was proposed in #1253
UPDATE, latest screenshots:

The three links are:

Also added compile pipeline documentation link in pipeline upload dialog:
download (23)
The link is: https://www.kubeflow.org/docs/pipelines/sdk/build-component/#compile-the-pipeline


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 9, 2019

Fixes #1253

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 9, 2019

video: https://drive.google.com/file/d/1HU76mAjDFCCRCz_QLiCaWs0_f0YF8UM9/view
This is my initial attempt, I didn't go for the design that collapse all three external links to a single "..." item because it needs some complex animation set up to make that fluent.

Any feedback?

@rmgogogo
Copy link
Contributor

/lgtm

@rmgogogo
Copy link
Contributor

hi Yuan, I just notice this PR.
Is it still on radar to be continued? Seems put there for days.

I'm generally OK. We have another working item which link the KFP with explicit cluster in GCP. It may require more changes and we can handle it in another PR.

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 29, 2019

Yes, I plan to finish this. After other things I've put a higher priority.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 5, 2019

FYI, I got the github icon from https://github.com/logos
It's recommended to be used when placed next to a link to github.

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Nov 5, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 5, 2019

/retest

1 similar comment
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 5, 2019

/retest

@rmgogogo
Copy link
Contributor

rmgogogo commented Nov 5, 2019

/lgtm

Thanks.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a0a420 into kubeflow:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants