Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.29 - 979396702e2d759db472cb44615377b2b3fb51ab #2060

Closed
wants to merge 4 commits into from
Closed

Release 1.29 - 979396702e2d759db472cb44615377b2b3fb51ab #2060

wants to merge 4 commits into from

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 7, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun Ark-kun changed the title Release 979396702e2d759db472cb44615377b2b3fb51ab Release 1.29 - 979396702e2d759db472cb44615377b2b3fb51ab Sep 7, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 7, 2019

/test kubeflow-pipeline-postsubmit

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 9, 2019

postsubmit test should work after #2063 is merged

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 9, 2019

/retest

@IronPan
Copy link
Member

IronPan commented Sep 10, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun force-pushed the release-979396702e2d759db472cb44615377b2b3fb51ab branch from 0cb5ce7 to 4e95065 Compare September 10, 2019 04:20
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 10, 2019
@Ark-kun
Merge branch 'master' of https://github.com/kubeflow/pipelines into r…
8f5475c 
…elease-979396702e2d759db472cb44615377b2b3fb51ab
@Ark-kun Ark-kun force-pushed the release-979396702e2d759db472cb44615377b2b3fb51ab branch from 4e95065 to 8f5475c Compare September 10, 2019 06:10
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 13, 2019

Initially, the postsubmit tests were failing due to the CloudBuild failures caused by moved deprecated components.
Then the postsubmit tests were failing, because they expected the container images to be build, but CloudBuild was not triggering for this branch.

The last postsubmit test failures were just due to CloudBuild taking too much time.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 16, 2019

Superseded by 0.1.30

@Ark-kun Ark-kun closed this Sep 16, 2019
@Ark-kun Ark-kun deleted the release-979396702e2d759db472cb44615377b2b3fb51ab branch September 23, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@IronPan IronPan

Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ark-kun @IronPan @k8s-ci-robot