Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: fix setting pipeline-wide artifact_location for ResourceOp and VolumeOp classes and add description field for create_experiment() function #2025

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

solovyevt
Copy link
Contributor

@solovyevt solovyevt commented Sep 3, 2019

Two things to update:

  1. Fix setting artifact_location for Pipeline, it crashes due to non-existence of artifact_location field in ResourceOp and VolumeOp classes.
  2. Add feature to add description to an experiment with dsl.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @solovyevt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 4, 2019

Thanks for your PR.
In future, please create separate PRs for separate issues so that they're easier to review and so that it's easier to understand the code annotations.
/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 4, 2019

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8fce006 into kubeflow:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants