Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend E2E tests: Add VolumeOp test #2019

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

elikatsis
Copy link
Member

@elikatsis elikatsis commented Sep 2, 2019

This PR adds E2E testing of volume_ops.

I will be adding tests for resource_ops in a following PR, also refactoring the related sample.


This change is Reviewable

* Rename: `samples/core/volume_ops/volumeop.py` ->
          `samples/core/volume_ops/volume_ops.py`
  for uniformity regarding test launching
* Change VolumeOp modes from RWM to RWO
@elikatsis
Copy link
Member Author

/test kubeflow-pipeline-sample-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 4, 2019

/lgtm
/cc @gaoning777

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0cc9f69 into kubeflow:master Sep 4, 2019
@elikatsis elikatsis deleted the resource-e2e-test-2 branch March 9, 2020 14:46
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Bumps [pillow](https://github.com/python-pillow/Pillow) from 6.2.0 to 9.0.0.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@6.2.0...9.0.0)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants