Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROC Curve visualization argument placeholder #2002

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Aug 30, 2019

This change is Reviewable

@ajchili ajchili changed the title Ajchili/fix roc curve argument placeholder Fix ROC Curve visualization argument placeholder Aug 30, 2019
@ajchili
Copy link
Member Author

ajchili commented Aug 30, 2019

/assign @IronPan @neuromage

@ajchili
Copy link
Member Author

ajchili commented Aug 30, 2019

/assing @rileyjbauer

@ajchili
Copy link
Member Author

ajchili commented Aug 30, 2019

This changes the argument placeholder shown to a user when generating an ROC curve. Currently, it shows incorrect arguments, this changes that and updates the method in which the arguments are obtained in the Python visualization.

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3cbbd87 into kubeflow:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants