Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable TFMA visualization #1986

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Disable TFMA visualization #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/components/viewers/VisualizationCreator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ class VisualizationCreator extends Viewer<VisualizationCreatorProps, Visualizati
.filter((key: string, i: number, arr: string[]) => {
const isDuplicate = arr.indexOf(key) !== i;
const isCustom = key === 'CUSTOM';
return !isDuplicate && (allowCustomVisualizations || !isCustom);
const isTFMA = key === 'TFMA';
return !isDuplicate && (allowCustomVisualizations || !isCustom) && !isTFMA;
});
}

Expand Down
66 changes: 0 additions & 66 deletions frontend/src/components/viewers/__snapshots__/VisualizationCreator.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@ exports[`VisualizationCreator disables all select and input fields when busy 1`]
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -127,12 +121,6 @@ exports[`VisualizationCreator does not render an Editor component if a visualiza
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -209,12 +197,6 @@ exports[`VisualizationCreator renders an Editor component if a visualization typ
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -336,12 +318,6 @@ exports[`VisualizationCreator renders component when all parameters in config ar
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -415,12 +391,6 @@ exports[`VisualizationCreator renders component when empty config is provided 1`
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -494,12 +464,6 @@ exports[`VisualizationCreator renders component when isBusy is not provided 1`]
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -573,12 +537,6 @@ exports[`VisualizationCreator renders component when onGenerate is not provided
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -652,12 +610,6 @@ exports[`VisualizationCreator renders the custom type when it is allowed 1`] = `
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -738,12 +690,6 @@ exports[`VisualizationCreator renders the provided arguments 1`] = `
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -866,12 +812,6 @@ exports[`VisualizationCreator renders the selected visualization type 1`] = `
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down Expand Up @@ -994,12 +934,6 @@ exports[`VisualizationCreator renders two Editor components if the CUSTOM visual
>
TFDV
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TFMA"
value="TFMA"
>
TFMA
</WithStyles(MenuItem)>
<WithStyles(MenuItem)
key="TABLE"
value="TABLE"
Expand Down