Add travis CI for new unit test. #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2019 21:09
Ark-kun
reviewed
Aug 27, 2019
.travis.yml
Outdated
| @@ -89,6 +89,12 @@ matrix: | |||
| # Component SDK tests | |||
| - cd $TRAVIS_BUILD_DIR/components/gcp/container/component_sdk/python | |||
| - ./run_test.sh | |||
|
|
|||
| # Sample test unittests. | |||
| - pip3 install minio | |||
There was a problem hiding this comment.
Maybe this can be moved to the install: section. https://docs.travis-ci.com/user/languages/python/#dependency-management
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ajchili
pushed a commit
to ajchili/pipelines
that referenced
this pull request
Aug 28, 2019
* Relocate unit test for sample test infra. * Relocate utils tests and add travis ci check. * Revert accidental change. * Lint * Fix travis build * Move dependencies to install section. * Fix travis build * Fix travis build * Fix travis build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed sample test infra unit test layout to make it clear this is not a part of sample test infra.
This change is